fix: harden skill template contracts and scaffolding

Align scaffold slug replacement, Action manifest strict boundaries, metadata prune API, field permission validation, and task_logs readonly semantics with documented template contracts.

Co-authored-by: Cursor <cursoragent@cursor.com>

tests/test_data_management_contract.py

@@ -75,11 +75,10 @@ DEMO_ITEMS_COLUMN_METADATA: tuple[dict[str, object], ...] = (
 )
 
 
-def _init_demo_items_fixture(conn: sqlite3.Connection) -> None:
+def _init_demo_items_fixture(conn: sqlite3.Connection, *, prune: bool = True) -> None:
     from db.display_metadata import (
         init_display_metadata_tables,
         list_physical_column_names,
-        prune_stale_column_metadata,
         seed_column_metadata_batch,
         upsert_table_metadata,
     )
@@ -96,9 +95,13 @@ def _init_demo_items_fixture(conn: sqlite3.Connection) -> None:
         visible=int(meta["visible"]),
         readonly=int(meta["readonly"]),
     )
-    seed_column_metadata_batch(cur, table_name="demo_items", columns=DEMO_ITEMS_COLUMN_METADATA)
     physical = list_physical_column_names(cur, "demo_items")
-    prune_stale_column_metadata(cur, "demo_items", physical)
+    seed_column_metadata_batch(
+        cur,
+        table_name="demo_items",
+        columns=DEMO_ITEMS_COLUMN_METADATA,
+        valid_column_names=physical if prune else None,
+    )
     conn.commit()
 
 
@@ -371,11 +374,16 @@ class TestDataManagementContract(unittest.TestCase):
                 """
             )
             conn.commit()
-            from db.display_metadata import list_physical_column_names, prune_stale_column_metadata
+            from db.display_metadata import list_physical_column_names, seed_column_metadata_batch
 
             cur = conn.cursor()
             physical = list_physical_column_names(cur, "demo_items")
-            prune_stale_column_metadata(cur, "demo_items", physical)
+            seed_column_metadata_batch(
+                cur,
+                table_name="demo_items",
+                columns=DEMO_ITEMS_COLUMN_METADATA,
+                valid_column_names=physical,
+            )
             conn.commit()
             cur.execute(
                 "SELECT 1 FROM _jiangchang_columns WHERE table_name = 'demo_items' AND column_name = 'removed_field'"
@@ -384,6 +392,77 @@ class TestDataManagementContract(unittest.TestCase):
         finally:
             conn.close()
 
+    def test_seed_batch_without_valid_column_names_does_not_prune(self) -> None:
+        conn = sqlite3.connect(":memory:")
+        try:
+            _init_demo_items_fixture(conn, prune=False)
+            conn.execute(
+                """
+                INSERT INTO _jiangchang_columns
+                (table_name, column_name, display_name, visible, searchable, editable)
+                VALUES ('demo_items', 'removed_field', '已删除', 0, 0, 0)
+                """
+            )
+            conn.commit()
+            from db.display_metadata import seed_column_metadata_batch
+
+            seed_column_metadata_batch(
+                conn.cursor(),
+                table_name="demo_items",
+                columns=DEMO_ITEMS_COLUMN_METADATA,
+            )
+            conn.commit()
+            cur = conn.cursor()
+            cur.execute(
+                "SELECT 1 FROM _jiangchang_columns WHERE table_name = 'demo_items' AND column_name = 'removed_field'"
+            )
+            self.assertIsNotNone(cur.fetchone())
+        finally:
+            conn.close()
+
+    def test_seed_batch_accepts_list_columns(self) -> None:
+        conn = sqlite3.connect(":memory:")
+        try:
+            _init_demo_items_fixture(conn, prune=False)
+            from db.display_metadata import get_column_editable, seed_column_metadata_batch
+
+            columns = list(DEMO_ITEMS_COLUMN_METADATA)
+            columns[1] = {**columns[1], "display_name": "标题（列表）"}
+            seed_column_metadata_batch(
+                conn.cursor(),
+                table_name="demo_items",
+                columns=columns,
+                valid_column_names=[str(item["column_name"]) for item in DEMO_ITEMS_COLUMN_METADATA],
+            )
+            conn.commit()
+            cur = conn.cursor()
+            cur.execute(
+                "SELECT display_name FROM _jiangchang_columns WHERE table_name = 'demo_items' AND column_name = 'title'"
+            )
+            self.assertEqual(cur.fetchone()[0], "标题（列表）")
+            self.assertEqual(get_column_editable(cur, "demo_items", "title"), 1)
+        finally:
+            conn.close()
+
+    def test_prune_does_not_remove_existing_column_metadata(self) -> None:
+        conn = sqlite3.connect(":memory:")
+        try:
+            _init_demo_items_fixture(conn)
+            from db.display_metadata import get_column_editable, seed_column_metadata_batch
+
+            cur = conn.cursor()
+            before = get_column_editable(cur, "demo_items", "title")
+            seed_column_metadata_batch(
+                cur,
+                table_name="demo_items",
+                columns=DEMO_ITEMS_COLUMN_METADATA,
+                valid_column_names=[str(item["column_name"]) for item in DEMO_ITEMS_COLUMN_METADATA],
+            )
+            conn.commit()
+            self.assertEqual(get_column_editable(cur, "demo_items", "title"), before)
+        finally:
+            conn.close()
+
     def test_demo_items_validation_passes(self) -> None:
         conn = sqlite3.connect(":memory:")
         try: